-
Notifications
You must be signed in to change notification settings - Fork 19
[ITEP:83537] Orchestrator Component Status Service #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # Cluster Orchestration - Enabled when cluster-orch profile is loaded | ||
| # Detection - enable-cluster-orch.yaml in root-app valueFiles | ||
| cluster-orchestration: | ||
| installed: {{ index .Values.argo.enabled "cluster-manager" | default false }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plus the cluster-management check are on the same setting but if only capi is installed then the status service will say that cluster-orchestration is disabled. Shouldn't the check here be to see if any cluster-management, capi or intel-provider are installed and, if at least one is enabled, then cluster-orchestration is considered enabled?
| # Observability - Enabled when o11y profile is loaded | ||
| # Detection - enable-o11y.yaml in root-app valueFiles | ||
| observability: | ||
| installed: {{ index .Values.argo.enabled "orchestrator-observability" | default false }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since orchestrator and edge node observability pipelines are separate and can be deployed independently of each other, instead of having observability shown as installed if one pipeline is enabled, we should have separate status checks for each pipelines, e.g.
orchestrator-observability:
installed: {{ index .Values.argo.enabled "orchestrator-observability" | default false }}
...
edgenode-observability:
installed: {{ index .Values.argo.enabled "edgenode-observability" | default false }}
Using a single status to cover both pipeline statuses will cause confusion on which pipeline is enabled if only the observability: installed value is checked
Description
HTTP service that provides information about installed components and features in an Edge Orchestrator deployment.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Changes has been tested with orch-cli using
Checklist: